chore: Add CustomLoader component and integrate with loading states in Admin, Flow, and Main pages #6047
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Admin, Flow, and Main pages
dosubot
bot
added
the
size:M
github-actions
bot
added
enhancement
deon-sanchez
added
chore
deon-sanchez
changed the title
github-actions
bot
added
enhancement
mfortman11
requested changes
Feb 7, 2025
dosubot
bot
added
size:S
dosubot
bot
added
size:M
mfortman11
approved these changes
Feb 7, 2025
Cristhianzl
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
CustomLoadercomponent and integrates it into several pages, controlled by theENABLE_DATASTAX_LANGFLOWfeature flag. The most important changes include the creation of theCustomLoadercomponent, and its conditional usage in different parts of the application based on the feature flag.Creation of
CustomLoadercomponent:src/frontend/src/customization/components/custom-loader.tsx: Added a newCustomLoadercomponent.Integration of
CustomLoadercomponent:src/frontend/src/pages/AdminPage/index.tsx: ImportedCustomLoaderandENABLE_DATASTAX_LANGFLOW, and conditionally renderedCustomLoaderinstead ofLoadingComponentbased on the feature flag. [1] [2]src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx: ImportedCustomLoaderandENABLE_DATASTAX_LANGFLOW, and conditionally renderedCustomLoaderinstead ofLoadingComponentbased on the feature flag. [1] [2]src/frontend/src/pages/MainPage/pages/index.tsx: ImportedCustomLoaderandENABLE_DATASTAX_LANGFLOW, and conditionally renderedCustomLoaderinstead ofLoadingComponentbased on the feature flag. [1] [2]Additionally, a comment was added to retain a specific section of code for LFOSS:
src/frontend/src/modals/apiModal/utils/get-curl-code.tsx: Added a comment to retain code for LFOSS.