Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance ChatMessage loading state management #6196

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

Cristhianzl
Copy link
Member

This pull request includes changes to the ChatMessage component in the chat-message.tsx file to enhance its functionality by incorporating a new state from the flow store.

The most important changes include:

Enhancements to ChatMessage component:

  • Added isBuilding state from useFlowStore to track the building state. (src/frontend/src/modals/IOModal/components/chatView/chatMessage/chat-message.tsx)
  • Updated the isLoading condition to include isBuilding and lastMessage for better state management. (src/frontend/src/modals/IOModal/components/chatView/chatMessage/chat-message.tsx)

…ssage is being built to improve user experience
@Cristhianzl Cristhianzl self-assigned this Feb 7, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 7, 2025
@Cristhianzl Cristhianzl requested review from lucaseduoli and removed request for ogabrielluiz February 7, 2025 17:28
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Feb 7, 2025
@github-actions github-actions bot added the enhancement New feature or request label Feb 7, 2025
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 11, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 11, 2025
@Cristhianzl Cristhianzl added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 11, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 11, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 3ea8e72 Feb 11, 2025
22 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/fix-lock-agent-chat branch February 11, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants