feat: Use Alembic with async driver #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
cbornet
commented
Feb 11, 2025
| # Even though the docs say this is the default, it raises an error | ||
| # if we don't specify it. | ||
| # https://docs.sqlalchemy.org/en/20/errors.html#pool-class-cannot-be-used-with-asyncio-engine-or-vice-versa | ||
| pool = AsyncAdaptedQueuePool |
There was a problem hiding this comment.
Not needed anymore since we upgrade sqlalchemy to 2.0.38
cbornet
changed the title
github-actions
bot
added
enhancement
cbornet
force-pushed
the
async-alembic
branch
2 times, most recently
from
6d77111 to
b01eb04
Compare
github-actions
bot
added
enhancement
cbornet
force-pushed
the
async-alembic
branch
2 times, most recently
from
4fdcf8b to
8e26821
Compare
github-actions
bot
added
enhancement
dosubot
bot
added
size:XXL
cbornet
force-pushed
the
async-alembic
branch
from
5b28132 to
a2a3ae5
Compare
dosubot
bot
removed
the
size:XXL
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
cbornet
commented
Feb 11, 2025
| @@ -75,6 +75,12 @@ def blockbuster(request): | |||
| .can_block_in("langchain_core/_api/internal.py", "is_caller_internal") | |||
| ) | |||
|
|
|||
| for func in ["os.stat", "os.path.abspath", "os.scandir"]: | |||
| bb.functions[func].can_block_in("alembic/util/pyfiles.py", "load_python_file") | |||
There was a problem hiding this comment.
Alembic makes a few blocking os calls. Now that we use the async driver, these calls will happen on the event loop. These shouldn't have a big impact as thses blockings are short and migrations happen only at startup.
|
Should fix #5495 |
github-actions
bot
added
enhancement
cbornet
force-pushed
the
async-alembic
branch
from
e9e7ebe to
9931ba6
Compare
dosubot
bot
added
size:L
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://alembic.sqlalchemy.org/en/latest/cookbook.html#using-asyncio-with-alembic