Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Added AP to rule ID:POSSESSIVE_WITHOUT_ARTICLE #11229

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Feb 6, 2025

An antipattern.

Summary by CodeRabbit

  • New Features
    • Enhanced Portuguese grammar checking with improved suggestions for proper usage in exclamatory contexts involving possessive pronouns.

Copy link
Contributor

coderabbitai bot commented Feb 6, 2025

Walkthrough

This pull request introduces several new antipattern rules to the Portuguese grammar file within LanguageTool. The new rules target exclamatory sentences using possessive pronouns, detecting incorrect usage and suggesting corrections. Each rule is structured with conditions and examples demonstrating both the error and the proper grammatical form for clarity.

Changes

File Change Summary
languagetool-language-modules/pt/.../grammar.xml Added new antipattern rules for exclamatory sentences involving possessive pronouns.

Possibly related issues

Possibly related PRs

Suggested reviewers

  • jaumeortola

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 51ac2de and e5cea3d.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/grammar.xml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments (4)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/grammar.xml (4)

907-920: Added antipattern for exclamations with possessive pronouns

The first antipattern (#1/3) handles exclamatory sentences containing possessive pronouns, preventing false positives in cases like:

  • "Seu cabelo lindo como sempre!"
  • "Minha paixão nessa vida é viajar!"
  • "Nossa... que descoberta!"

The pattern matches:

  1. Start of sentence or comma
  2. Possessive pronoun (DP tag) with no other possessive pronoun following
  3. Exclamation mark

921-931: Added antipattern for specific exclamation cases

The second antipattern (#2/3) handles exclamatory sentences with articles/prepositions between possessives, like:

  • "Sua Beleza é a nossa satisfação!"
  • "Nossos profissionais estão esperando a sua ligação!"

This complements the first antipattern by catching cases that would be missed due to the DP tag exception.


931-944: Added antipattern for complex exclamation cases

The third antipattern (#3/3) handles more complex exclamatory sentences with multiple possessives and verbs, like:

  • "Sua resenha me ajudou a criar a minha opinião sobre esse livro!"
  • "SEU COMENTÁRIO IRÁ NOS AJUDAR A MELHORAR A NOSSA LOJA!"

This ensures that legitimate uses of multiple possessives in exclamatory sentences are not flagged as errors.


945-963: Added antipattern for possessive pronouns with specific nouns

This antipattern prevents false positives when possessive pronouns are used with certain nouns like "ministro", "agente", "colega", etc. The pattern matches:

  • Possessive pronoun (DP tag)
  • Noun from the predefined list pronomes_possessivos_excecoes_a_o_pt_pt

This helps avoid flagging valid constructions like:

  • "Seu irmão mais novo, Vladislau, sucedeu-o no trono da Sérvia."
  • "Em 1981 formou o duo Wham!, com seu colega de escola, Andrew Ridgeley."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcoagpinto marcoagpinto merged commit 8c79605 into master Feb 6, 2025
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20250206_1220 branch February 6, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant