Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stackable on_key_down and on_key_up event handlers #255

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 4, 2024

This adds stackable on_key_down and on_key_up event handlers.

@jrmoulton
Copy link
Collaborator

Should this be extended to all event handler?
I'm running into the same problem with on_focus on text input

.on_event_stop(EventListener::FocusGained, move |_| {

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 4, 2024

Yeah, we probably want all view decorators to stack in general.

@dzhou121 dzhou121 merged commit 79490b1 into lapce:main Jan 4, 2024
7 checks passed
@Zoxc Zoxc deleted the key-events branch January 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants