Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export IconExtWindows #745

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Export IconExtWindows #745

merged 5 commits into from
Feb 7, 2025

Conversation

cyberdoors
Copy link
Contributor

Export IconExtWindows, support loading icons from resources

src/window.rs Outdated Show resolved Hide resolved
@panekj panekj changed the title 导出IconExtWindows,使windows支持使用Icon::from_resource从资源resource中加载icon Export IconExtWindows Jan 25, 2025
Co-authored-by: Jakub Panek <me@panekj.dev>
@jrmoulton
Copy link
Collaborator

This looks good. It just needs rustfmt to run.

@panekj
Copy link
Collaborator

panekj commented Feb 4, 2025

You need to fix formatting issue with rustfmt too

Copy link
Contributor Author

@cyberdoors cyberdoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cargo fmt

@panekj panekj merged commit a49bc20 into lapce:main Feb 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants