Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #56

Merged
merged 1 commit into from
May 10, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/Presenter.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "laracasts/presenter": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@ariaieboy
Copy link

cc:
@JeffreyWay

@derekmd
Copy link

derekmd commented Apr 21, 2024

The "illuminate/support" dependency could be removed. src/ and its /spec tests don't have any use Illuminate\Support\ or Laravel global helper references.

@MattApril
Copy link

The "illuminate/support" dependency could be removed. src/ and its /spec tests don't have any use Illuminate\Support\ or Laravel global helper references.

Pull request #57 submitted

@JeffreyWay JeffreyWay merged commit fa70a69 into laracasts:master May 10, 2024
@MattApril
Copy link

@JeffreyWay what's the reason for merging this PR instead of #57?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants