Do not assume that the sid sent to client is the account sid #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twilio allows for the creation of api keys and tokens that can (arguably should) be used in lieu of the account sid and its token. Using the account sid and its token puts credentials in the wild that have the power to create new api keys and perform account-level operations that are not required or often appropriate for a system that just sends messages. This PR simply adds another configuration key
sidthat defaults toaccount_sidif it's not set. So now the user can configure the package to use an api key sid and its token, but if not, the package will continue to function exactly as it did before.