Strengthen factory generator tests

laravel-shift · Jan 29, 2020 · eb24b88 · eb24b88
1 parent 1e30d38
commit eb24b88
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 4 deletions.
diff --git a/src/Generators/FactoryGenerator.php b/src/Generators/FactoryGenerator.php
@@ -92,6 +92,8 @@ protected function buildDefinition(Model $model)
     protected function fakerData(string $name)
     {
         static $fakeableNames = [
+            'address1' => 'streetAddress',
+            'address2' => 'secondaryAddress',
             'city' => 'city',
             'company' => 'company',
             'content' => 'paragraphs(3, true)',
@@ -111,12 +113,11 @@ protected function fakerData(string $name)
             'password' => 'password',
             'phone' => 'phoneNumber',
             'phone_number' => 'phoneNumber',
-            'postcode' => 'postcode',
             'postal_code' => 'postcode',
+            'postcode' => 'postcode',
             'slug' => 'slug',
+            'ssn' => 'ssn',
             'street' => 'streetName',
-            'address1' => 'streetAddress',
-            'address2' => 'secondaryAddress',
             'summary' => 'text',
             'title' => 'sentence(4)',
             'url' => 'url',

diff --git a/tests/Feature/Generator/FactoryGeneratorTest.php b/tests/Feature/Generator/FactoryGeneratorTest.php
@@ -91,7 +91,8 @@ public function modelTreeDataProvider()
             ['definitions/post.bp', 'database/factories/PostFactory.php', 'factories/post.php'],
             ['definitions/team.bp', 'database/factories/TeamFactory.php', 'factories/team.php'],
             ['definitions/unconventional.bp', 'database/factories/TeamFactory.php', 'factories/unconventional.php'],
-            ['definitions/nested-components.bp', 'database/factories/Admin/UserFactory.php', 'factories/nested-components.php']
+            ['definitions/nested-components.bp', 'database/factories/Admin/UserFactory.php', 'factories/nested-components.php'],
+            ['definitions/model-modifiers.bp', 'database/factories/ModifierFactory.php', 'factories/model-modifiers.php']
         ];
     }
 }
diff --git a/tests/fixtures/factories/model-modifiers.php b/tests/fixtures/factories/model-modifiers.php
@@ -0,0 +1,17 @@
+<?php
+
+/** @var \Illuminate\Database\Eloquent\Factory $factory */
+
+use App\Modifier;
+use Faker\Generator as Faker;
+
+$factory->define(Modifier::class, function (Faker $faker) {
+    return [
+        'title' => $faker->sentence(4),
+        'name' => $faker->name,
+        'content' => $faker->paragraphs(3, true),
+        'total' => $faker->randomFloat(),
+        'ssn' => $faker->ssn,
+        'role' => $faker->randomElement(["user","admin","owner"]),
+    ];
+});