Allow external Prism providers in PrismGateway#284
Open
meirdick wants to merge 1 commit intolaravel:0.xfrom
Open
Allow external Prism providers in PrismGateway#284meirdick wants to merge 1 commit intolaravel:0.xfrom
meirdick wants to merge 1 commit intolaravel:0.xfrom
Conversation
The toPrismProvider() method previously threw an InvalidArgumentException for any driver not in its hardcoded match statement. This prevented external Prism providers registered via PrismManager::extend() — such as prism-php/bedrock or custom Workers AI providers — from being used through the agent() system. Since Prism's using() method already accepts string|ProviderEnum and PrismManager::resolve() already handles custom providers via extend(), the fix is to return the driver name as a string for unrecognized drivers instead of throwing. Prism's own resolution handles the error case if the provider is truly unregistered. Closes laravel#283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toPrismProvider()now returns the driver name as a string for unrecognized drivers instead of throwingInvalidArgumentExceptionPrismProvidertoPrismProvider|string(matches whatPrism::using()already accepts)PrismProviderenum values — zero behavior change for current usersProblem
External Prism providers registered via
PrismManager::extend()— like prism-php/bedrock (100k+ Packagist downloads) — cannot be used through theagent()system becausetoPrismProvider()throws for any driver not in its hardcoded match.The Prism layer already supports this:
Prism::using()acceptsstring|ProviderEnum, andPrismManager::resolve()checkscustomCreatorsfirst. The gap is only in the Laravel AI gateway layer.Fix
The string driver name flows through to
Prism::using()→PrismManager::resolve()which resolves custom providers viaextend(), or throws its ownInvalidArgumentException("Provider [{$name}] is not supported.")if truly unknown.Test plan
PrismProviderenum values'bedrock','workers-ai') return the driver name as a stringCloses #283