Skip to content

Commit

Permalink
Merge branch '10.x' into 11.x
Browse files Browse the repository at this point in the history
# Conflicts:
#	CHANGELOG.md
#	src/Illuminate/Foundation/Application.php
  • Loading branch information
driesvints committed Apr 30, 2024
2 parents 44dba84 + 470e3e8 commit 5d06b37
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/releases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,11 @@ jobs:
- name: Cleanup release notes
id: cleaned-notes
run: |
NOTES="${{ steps.generated-notes.outputs.release-notes }}"
NOTES=$(echo $NOTES | sed '/## What/d')
NOTES=$(echo $NOTES | sed '/## New Contributors/,$d')
echo "release-notes=${NOTES}" >> "$GITHUB_OUTPUT"
env:
NOTES: ${{ steps.generated-notes.outputs.release-notes }}

- name: Create release
uses: softprops/action-gh-release@v2
Expand Down
1 change: 1 addition & 0 deletions src/Illuminate/Database/DetectsLostConnections.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ protected function causedByLostConnection(Throwable $e)

return Str::contains($message, [
'server has gone away',
'Server has gone away',
'no connection to the server',
'Lost connection',
'is dead or not enabled',
Expand Down
4 changes: 4 additions & 0 deletions src/Illuminate/Foundation/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,10 @@ public function storagePath($path = '')
return $this->joinPaths($this->storagePath ?: $_ENV['LARAVEL_STORAGE_PATH'], $path);
}

if (isset($_SERVER['LARAVEL_STORAGE_PATH'])) {
return $this->joinPaths($this->storagePath ?: $_SERVER['LARAVEL_STORAGE_PATH'], $path);
}

return $this->joinPaths($this->storagePath ?: $this->basePath('storage'), $path);
}

Expand Down
6 changes: 3 additions & 3 deletions tests/Routing/RoutingUrlGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ public function testSignedUrl()

$this->assertTrue($url->hasValidSignature($request));

$request = Request::create($url->signedRoute('foo').'?tempered=true');
$request = Request::create($url->signedRoute('foo').'?tampered=true');

$this->assertFalse($url->hasValidSignature($request));
}
Expand Down Expand Up @@ -827,7 +827,7 @@ public function testSignedRelativeUrl()

$this->assertTrue($url->hasValidSignature($request, false));

$request = Request::create($url->signedRoute('foo', [], null, false).'?tempered=true');
$request = Request::create($url->signedRoute('foo', [], null, false).'?tampered=true');

$this->assertFalse($url->hasValidSignature($request, false));
}
Expand Down Expand Up @@ -906,7 +906,7 @@ public function testSignedUrlWithKeyResolver()

$this->assertTrue($url->hasValidSignature($request));

$request = Request::create($url->signedRoute('foo').'?tempered=true');
$request = Request::create($url->signedRoute('foo').'?tampered=true');

$this->assertFalse($url->hasValidSignature($request));

Expand Down

0 comments on commit 5d06b37

Please sign in to comment.