[11.x] Allow sorting routes by precedence in artisan routes:list. #53706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing for a unrelated reason. |
mathieutu
changed the title
mathieutu
commented
Nov 29, 2024
Comment on lines
119
to
123
| if (($sort = $this->option('sort')) !== null) { | ||
| $routes = $this->sortRoutes($sort, $routes); | ||
| } else { | ||
| $routes = $this->sortRoutes('uri', $routes); | ||
| } |
There was a problem hiding this comment.
The option is by 'uri' by default, so it seems not needed, as it's never null. I added a test to be sure of it.
|
Renamed option to |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
By default, routes are sorted by
uri.However, it's not easy to see which routes will take precedence on the others (especially when routes are coming from a package).
This PR adds a
--sort=precedenceoption to display the routes by their original order.It also removes useless code, and adds a test to be sure we don't have any regression.
PS: in the edge case where an array is passed like
['domain', 'precedence'], it still will work as planned, as null will be compared to null in the sort callback.Thanks.
Mathieu.