[11.x] Update PHPStan to 2.x #53716
[11.x] Update PHPStan to 2.x #53716
Conversation
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
All those hard-coded integers seem kinda weird? |
| @@ -258,6 +258,7 @@ public function run(array|string|null $command = null, ?callable $output = null) | |||
|
|
|||
| return new ProcessResult(tap($process)->run($output)); | |||
| } catch (SymfonyTimeoutException $e) { | |||
| /** @phpstan-ignore variable.undefined */ | |||
There was a problem hiding this comment.
Ignoring errors doesn't seem right.
Maybe move $process = $this->toSymfonyProcess($command); out of the try section instead?
There was a problem hiding this comment.
Indeed. Fixed in 7ce889a.
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| use function PHPStan\Testing\assertType; | |||
|
|
|||
| new class implements ValidationRule | |||
| $class = new class implements ValidationRule | |||
There was a problem hiding this comment.
| $class = new class implements ValidationRule | |
| new class implements ValidationRule |
There was a problem hiding this comment.
The instance must be assigned to some variable to avoid the following error...
------ -----------------------------------------------------------------------------------------------------------------------------
Line ValidationRule.php
------ -----------------------------------------------------------------------------------------------------------------------------
7 Expression "new class implements \Illuminate\Contracts\Validation\ValidationRule…" on a separate line does not do anything.
🪪 expr.resultUnused
------ -----------------------------------------------------------------------------------------------------------------------------
There was a problem hiding this comment.
The error is valid, but the real problem is something else
Looking at the entire file, it doesn't seem like it's testing anything. The class is being instantiated, but the assertion call is inside a method that isn't being called.
I'd rather see the test being reworked so there's a point in even having it.
| assertType('36', $cache->remember('cache', now(), function (): int { | ||
| return 36; | ||
| })); |
There was a problem hiding this comment.
I would assume that a callback with int return type would result in a type called int and not 36. There seems to be a problem elsewhere.
All these type assertions should remain unchanged.
There was a problem hiding this comment.
I think that since PHPStan 2.0, types are inferred more narrowly, in this case as 36 literal type.
https://phpstan.org/writing-php-code/phpdoc-types#literals-and-constants
There was a problem hiding this comment.
I hope that's something that can be configured somewhere, since the returned type is a string with the number, so the "literal" part is misleading.
PHPStan 2.0 has been released so this pull request updates PHPStan version to 2.x.
Most of the fixes are under types/.