Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Add hasMorePages() to CursorPaginator contract #53762

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

KennedyTedesco
Copy link
Contributor

All the cursorPaginate() methods in different implementations return the CursorPaginator contract, like this one:

https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Query/Builder.php#L3222

/**
 * @return \Illuminate\Contracts\Pagination\CursorPaginator
 */
public function cursorPaginate($perPage = 15, $columns = ['*'], $cursorName = 'cursor', $cursor = null)

However, unlike the regular Paginator contract, the CursorPaginator does not include the hasMorePages() method.

@taylorotwell taylorotwell merged commit d654523 into laravel:master Dec 6, 2024
40 checks passed
@KennedyTedesco KennedyTedesco deleted the cursor-paginator branch December 6, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants