[11.x] Ignore health endpoint when in maintenance mode #53772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if you use any liveliness or readiness checks in your app such as with Kubernetes, if you put the app into maintenance mode, it clobbers the health endpoint and starts returning 503 response, which triggers the infra to spin up new containers in an attempt to resolve the unhealthy containers... This we do not not to happen. This PR puts the health endpoint into the exception list for preventing requests during maintenance.
browner12
pushed a commit
to browner12/framework
that referenced
this pull request
Dec 10, 2024
* Ignore health endpoint when in maintenance mode Currently if you use any liveliness or readiness checks in your app such as with Kubernetes, if you put the app into maintenance mode, it clobbers the health endpoint and starts returning 503 response, which triggers the infra to spin up new containers in an attempt to resolve the unhealthy containers... This we do not not to happen. This PR puts the health endpoint into the exception list for preventing requests during maintenance. * style fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you use any liveliness or readiness checks in your app such as with Kubernetes, if you put the app into maintenance mode, it clobbers the health endpoint and starts returning 503 response, which triggers the infra to spin up new containers in an attempt to resolve the unhealthy containers... This we do not want to happen.
This PR puts the health endpoint into the exception list for preventing requests during maintenance.