Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: sample rate added #1516

Closed
wants to merge 3 commits into from

Conversation

mhkarimi1383
Copy link

@mhkarimi1383 mhkarimi1383 commented Sep 8, 2024

Added a sample rate config and isEnabled function to handle sample rates this will make this package more usable in bigger scales

Also for safety and to make it more reusable I made that set that telescope if it's enable or not in the context of request

If needed I can Also make isEnabled function customizable

NOTE: I'm not a PHP/Laravel dev so some mistakes in changes are possible

Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
@mhkarimi1383
Copy link
Author

Context is only available is laravel 11, what we have to do for older version?

Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
Signed-off-by: Muhammed Hussein Karimi <info@karimi.dev>
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants