Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

480 update thrust force mapping documentation and testing #180

Merged

Conversation

JulianHammerl
Copy link
Collaborator

@JulianHammerl JulianHammerl commented Jan 8, 2024

  • Tickets addressed: MAXGNC-480
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

A change was made to the thrForceMapping module to allow 3-axis attitude control with DV thrusters (previously it was assumed that this is not possible and only 2 axes could be controlled). This change was done without updating the documentation. This ticket updates the documentation and unit test.

Verification

The unit test passes.

Documentation

Documentation was updated.

Future work

N/A

@JulianHammerl JulianHammerl added the documentation Improvements or additions to documentation label Jan 8, 2024
@JulianHammerl JulianHammerl self-assigned this Jan 8, 2024
Copy link
Collaborator

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired

@JulianHammerl JulianHammerl force-pushed the 480-update-thrust-force-mapping-documentation-and-testing branch from 16906c4 to 67fc4c4 Compare January 23, 2024 18:33
@JulianHammerl JulianHammerl force-pushed the 480-update-thrust-force-mapping-documentation-and-testing branch from 67fc4c4 to efe9841 Compare January 23, 2024 18:40
@patkenneally patkenneally merged commit f20ab95 into develop Jan 23, 2024
2 checks passed
@patkenneally patkenneally deleted the 480-update-thrust-force-mapping-documentation-and-testing branch January 23, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants