Cielim data streaming #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/cielim-data-streaming
branch
from
6a548bd to
935dea3
Compare
patkenneally
force-pushed
the
feature/cielim-data-streaming
branch
4 times, most recently
from
086e1a4 to
e46fcb1
Compare
The ZMQ connector is intended to abstract away communication and protocol implementation.
patkenneally
force-pushed
the
feature/cielim-data-streaming
branch
from
e46fcb1 to
eb63924
Compare
patkenneally
force-pushed
the
feature/cielim-data-streaming
branch
from
eb63924 to
dfc192e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a message streaming module called Cielim interface. The interface module is largely a replication of the vizInterface module with minor changes. The primary change is the extraction of the ZMQ connection business logic from the module. This PR also duplicates the vizSupport
enableUnityVisualizationfunction with aenableCielimVisualizationfunction. Again the hope is to replicate functionality with the expectation that once Basilisk communicates with Cielim correctly, then we'll come back and significantly refactor these additions.Verification
Currently only manual testing available. This is done with the example scenario, and an instance of the Cielim application.
Documentation
None, needed yet.
Future work
Long term (3-6 months) these modules/additions will be significantly refactored to become a general Basilisk message streaming API.