Add pre-commit workflow #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brsm3129
force-pushed
the
feature/pre-commit-ci
branch
from
93e7b17 to
b5d24c3
Compare
brsm3129
force-pushed
the
feature/pre-commit-ci
branch
8 times, most recently
from
cf8c640 to
c8440fe
Compare
brsm3129
force-pushed
the
feature/pre-commit-ci
branch
2 times, most recently
from
de1ca20 to
62abb69
Compare
brsm3129
force-pushed
the
feature/pre-commit-ci
branch
2 times, most recently
from
692561e to
f866b43
Compare
patkenneally
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new job to pull-request.yml that fetches all of the names of the files that have been changed then feeds those files into pre-commit. The tests that run on Windows and Linux have been set to wait for the pre-commit job to pass before starting.
Verification
These changes are verified by sending in files that need to be changed by pre-commit and expecting a stoppage of tests along with sending files that have already been checked by pre-commit and expecting a pass.
Documentation
No documentation added or invalidated.
Future work
Consider making the other tests start up as pre-commit is running and cancelling them early if pre-commit fails.