Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conan cache to windows using github actions #230

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

brsm3129
Copy link
Collaborator

@brsm3129 brsm3129 commented Apr 24, 2024

  • Tickets addressed: maxgnc-895
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This branch moves all dependency files created on windows github runners to C:\users\runneradmin\.conan, and caches this folder between CI runs. There is no change outside of github actions.
This branch also touches the linux build as it is more descriptive of which keys it accepts when grabbing caches

Verification

No new tests added, there should be no change in output, just how CI is ran.

Documentation

No documentation added

Future work

None currently, maybe if cache sizes increase we will need to move away from github's cache

@brsm3129 brsm3129 self-assigned this Apr 24, 2024
@brsm3129 brsm3129 force-pushed the feature/conan-cache-windows branch 4 times, most recently from 762ad4c to bcbd5e3 Compare May 10, 2024 17:45
@brsm3129 brsm3129 force-pushed the feature/conan-cache-windows branch 7 times, most recently from 0d8a5d8 to 7d81b05 Compare June 5, 2024 19:01
@brsm3129 brsm3129 marked this pull request as ready for review June 5, 2024 19:15
@brsm3129 brsm3129 force-pushed the feature/conan-cache-windows branch from 0a74ad6 to 0e64e1a Compare June 5, 2024 19:25
@brsm3129 brsm3129 requested a review from patkenneally June 5, 2024 20:20
@brsm3129 brsm3129 force-pushed the feature/conan-cache-windows branch 2 times, most recently from 41e640a to 4be510a Compare June 7, 2024 16:39
@brsm3129 brsm3129 force-pushed the feature/conan-cache-windows branch from 4be510a to e741d12 Compare June 10, 2024 19:48
@patkenneally patkenneally merged commit 4476026 into develop Jun 10, 2024
3 checks passed
@patkenneally patkenneally deleted the feature/conan-cache-windows branch June 10, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants