Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/886 signal processing cpp #232

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

thibaudteil
Copy link
Collaborator

  • Tickets addressed: bsk-886
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR adds a cpp signal processing capability for low pass filtering. It is the same as the c method, except with a unit test

Verification

google test to check frequency content of the signal, the reduction of noise, and the setters and getters

Documentation

None

Future work

None

Copy link
Collaborator

@codyallard28 codyallard28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

@thibaudteil thibaudteil force-pushed the feature/886-signalProcessing-cpp branch 3 times, most recently from b739f63 to 15895b1 Compare May 10, 2024 21:56
@thibaudteil thibaudteil force-pushed the feature/886-signalProcessing-cpp branch 10 times, most recently from d436577 to ce79798 Compare May 26, 2024 01:34
@thibaudteil thibaudteil force-pushed the feature/886-signalProcessing-cpp branch from ce79798 to 5767600 Compare June 3, 2024 21:49
@thibaudteil thibaudteil force-pushed the feature/886-signalProcessing-cpp branch from 5767600 to 99d0805 Compare June 6, 2024 19:53
@patkenneally patkenneally force-pushed the feature/886-signalProcessing-cpp branch from 99d0805 to a66090c Compare June 6, 2024 20:09
@patkenneally patkenneally merged commit dcac359 into develop Jun 6, 2024
@patkenneally patkenneally deleted the feature/886-signalProcessing-cpp branch June 6, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants