Upgrade dependency to opencv4.5.5 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/upgrade-opencv-4-5-5
branch
2 times, most recently
from
b6978cc to
94f3c68
Compare
thibaudteil
approved these changes
May 2, 2024
File format was WebP, rather than PNG as indicated by the file extension. The format is now PNG.
Previously <ifstream> was being included by happenstance. Instead, includes used in the file should all be explicit.
patkenneally
force-pushed
the
feature/upgrade-opencv-4-5-5
branch
from
94f3c68 to
8b2f45d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading OpenCV dependency from 4.1.2 to 4.5.5.
With previous OpenCV includes,
<ifstream>was being included by happenstance. Instead, file includes should all be explicit.Verification
CI should run and tests pass.
Documentation
None new needed and none invalidated.
Future work
None