Target use math macros from cmake #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows to make certain math macros like M_PI squash
thibaudteil
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows to make available certain math macros like M_PI the _USE_MATH_MACROS macro must be defined. The usage of the macro is not understood by module developers as evidence by its random scattering through some files and not others, or where the developer has luckily (unbeknownst to them) included astroConstants.h which declares the macro.
The first commit defines the macro as a parameter to the compiler in Cmake for all files in a Windows build. As a result this macro no longer needs to be defined on a case by cases basis.
Verification
CI runs and passes
Documentation
None new, none invalidated.
Future work
None