Feature/894 hill point cpp #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyallard28
force-pushed
the
feature/894-hillPoint-cpp
branch
4 times, most recently
from
6dcd433 to
f516d11
Compare
codyallard28
force-pushed
the
feature/894-hillPoint-cpp
branch
2 times, most recently
from
d40a18b to
48bcd75
Compare
codyallard28
force-pushed
the
feature/894-hillPoint-cpp
branch
from
54e89c9 to
f606d29
Compare
codyallard28
force-pushed
the
feature/894-hillPoint-cpp
branch
from
f606d29 to
c1f277e
Compare
codyallard28
requested review from
JulianHammerl and
leahkiner
and removed request for
thibaudteil and
JulianHammerl
codyallard28
force-pushed
the
feature/894-hillPoint-cpp
branch
from
31738f5 to
4e3855d
Compare
leahkiner
approved these changes
Jul 11, 2024
codyallard28
force-pushed
the
feature/894-hillPoint-cpp
branch
from
4e3855d to
6454caa
Compare
patkenneally
force-pushed
the
feature/894-hillPoint-cpp
branch
from
6454caa to
c776391
Compare
patkenneally
force-pushed
the
feature/894-hillPoint-cpp
branch
from
c776391 to
a25b4b7
Compare
patkenneally
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The C version of hillPoint is ported to C++ resulting in the new hillPointCpp module. Eigen was used to replace the matrix math. Some clean up was completed along the way.
Verification
Using the previous test of hillPoint, test_hillPointCpp tests pass.
Documentation
The documentation was copied over from hillPoint
Future work
None