Feature/834 com cob offset #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
approved these changes
May 10, 2024
src/fswAlgorithms/opticalNavigation/cobConverter/cobConverter.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/opticalNavigation/cobConverter/cobConverter.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/opticalNavigation/cobConverter/cobConverter.cpp
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/opticalNavigation/cobConverter/_UnitTest/test_cobConverter.py
Show resolved
Hide resolved
JulianHammerl
force-pushed
the
feature/834-com-cob-offset
branch
3 times, most recently
from
b711f3f to
0e9e02f
Compare
JulianHammerl
force-pushed
the
feature/834-com-cob-offset
branch
from
0e9e02f to
1a12fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cobConverter module was updated to include the center of mass (COM) offset estimation due to the phase angle correction. In addition to the unit vector pointing to the center of brightness (COB), the module now outputs another message containing the unit vector pointing to the center of mass (COM) as well as an output message containing more information about the COM computation. The noise (covariance matrix) for the COM unit vector is the same as for the COB unit vector.
The module now requires an input parameter to specify which method should be used to compute the phase angle correction ("NoCorrection" needs to be chosen to not apply any correction).
Verification
The UnitTest was updated accordingly.
Documentation
The documentation was updated accordingly.
Future work
N/A