Revert cileimInterface ImageData from using to plain struct
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
changed the title
using to plain struct
patkenneally
changed the title
using to plain structImageData from using to plain struct
thibaudteil
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
usingkeyword is handled differently at the linkage stage in GCC (9.5) compared to Clang (and others). It is fair to assume it's comparable totypedefbut not so. A good discussion of this is contained here.Verification
CI tests run and pass.
Documentation
None new and none invalidated.
Future work
The implementation here of a
structis itself not a good choice. Rather, it should be converted to either a class, or something like a std::pair<>.