Fail conanfile with compile fail #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
ci/fail-conanfile-with-compile-fail
branch
from
79d093f to
0a90098
Compare
Checking the return code will ensure that if the subprocess fails then the conanfile fails. This is correct and as a nice side effect it ensures that the github action step fails when the build fails. Additionally, os.system is not the recommend method to run a subprocess.
patkenneally
force-pushed
the
ci/fail-conanfile-with-compile-fail
branch
from
0a90098 to
666e677
Compare
joaogvcarneiro
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, if the sub process that called
conan.build()failed (e.g. compilation failed) the sub process return code was ignored and the conanfile execution would return as successful. Of course, this is incorrect behavior. This PR modifies the sub process call and checks the return code. If the return code is not 0 (success) then an exception is thrown and theconanfile.pyexecution fails. As a nice side effect, because the conanfile.py execution fails, then the encapsulating github action step fails when the build fails (which didn't happen previously). Additionally, os.system is not the recommend method to run a sub process and this PR changes to usesubprocesspackage.Verification
CI runs successfully. Also a purposeful compilation error was added to
spacecraft.cppand the CI run to demonstrate the failingconanfile.pyexecution. See CI run https://github.com/lasp/basilisk/actions/runs/9037970400Documentation
None new, none invalidated.
Future work
None