Remove unused includes

[patkenneally]

• Tickets addressed: NA
• Review: By commit
• Merge strategy: Merge (no squash)

Description

The Basilisk code base is has many unused includes. This is wasted effort during compilation as the compiler often parses the include only to then never make use of that effort. This PR simply removes all unused includes.

Verification

CI runs successfully and by inspection the only changes should be removed includes.

Documentation

None new, none invalidated.

Future work

A tool like IWUYU should be added to prevent developers from merging code with unused includes.

[joaogvcarneiro]

It looks good. I wonder why you also don't remove some unnecessary "return "statements when you clean up. Is it because you feel that's more of a refactor, not a cleanup? I am just trying to understand your thought process.

[patkenneally]

It looks good. I wonder why you also don't remove some unnecessary "return "statements when you clean up. Is it because you feel that's more of a refactor, not a cleanup? I am just trying to understand your thought process.

You make a good point. Pre-commit checks only for formatting changes. As you correctly note, removing a return statement is more of a code change. In time we will add a static analysis step to the PR process which will be able check for such things.