-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/703 ephemeris based guidance #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678e133
to
5b97cf1
Compare
thibaudteil
approved these changes
May 23, 2024
...orithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.cpp
Show resolved
Hide resolved
patkenneally
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired
Nicely done.
...orithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.cpp
Outdated
Show resolved
Hide resolved
...orithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.cpp
Outdated
Show resolved
Hide resolved
...lgorithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.h
Outdated
Show resolved
Hide resolved
...orithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.cpp
Outdated
Show resolved
Hide resolved
...lgorithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.h
Outdated
Show resolved
Hide resolved
...orithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.cpp
Outdated
Show resolved
Hide resolved
...lgorithms/transDetermination/ephemDifferenceWithUncertainty/ephemDifferenceWithUncertainty.h
Show resolved
Hide resolved
5b97cf1
to
4797b5a
Compare
4797b5a
to
9bc6dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A module was created that takes the ephemeris message containing the position and velocity of two objects (a base object and a secondary object), and computes the relative position and velocity of the secondary with respect to the base. This is then written to a navigation and filter message.
Verification
A UnitTest was added.
Documentation
An rst documentation was added.
Future work
N/A