Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunlineSRuKF module #250

Merged
merged 8 commits into from
May 29, 2024
Merged

sunlineSRuKF module #250

merged 8 commits into from
May 29, 2024

Conversation

rcalaon
Copy link
Collaborator

@rcalaon rcalaon commented May 21, 2024

  • Tickets addressed: bsk-793
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Square root unscented kalman filter to estimate the sunline direction in body-frame coordinates using a combination of coarse sun sensor and rate gyro measurements.

Verification

The unit test tests the correctness of the propagation, the measurement processing, and state output of the filter compared to the measurement noise of the sensors.

Documentation

Documentation is provided.

Future work

The input navigation message will be substituted with input gyro message.

@rcalaon rcalaon added the enhancement New feature or request label May 21, 2024
@rcalaon rcalaon self-assigned this May 21, 2024
@rcalaon rcalaon linked an issue May 21, 2024 that may be closed by this pull request
@rcalaon rcalaon force-pushed the feature/217-sunlineSRuKF branch 2 times, most recently from f99eec9 to 5021d6b Compare May 21, 2024 18:53
Copy link
Collaborator

@thibaudteil thibaudteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Pat likes to squash all of the commits into one single huge one when PR'ing a new module, but I'm ok either way

@rcalaon rcalaon force-pushed the feature/217-sunlineSRuKF branch 3 times, most recently from 62e32a3 to b5ea2fa Compare May 24, 2024 18:58
Copy link
Collaborator

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired

@rcalaon rcalaon force-pushed the feature/217-sunlineSRuKF branch 2 times, most recently from 0989662 to d94d3da Compare May 28, 2024 18:50
@rcalaon rcalaon force-pushed the feature/217-sunlineSRuKF branch from d94d3da to 42d0a43 Compare May 28, 2024 18:53
@rcalaon rcalaon force-pushed the feature/217-sunlineSRuKF branch from 42d0a43 to 549f04a Compare May 28, 2024 18:59
@rcalaon rcalaon force-pushed the feature/217-sunlineSRuKF branch from 549f04a to 7fc4b34 Compare May 28, 2024 22:11
@patkenneally patkenneally merged commit 87bb15b into develop May 29, 2024
3 checks passed
@patkenneally patkenneally deleted the feature/217-sunlineSRuKF branch May 29, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

sunlineSRuKF
3 participants