Feature/833 cob windowing #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianHammerl
force-pushed
the
feature/833-cob-windowing
branch
from
043ef91 to
a17cea8
Compare
patkenneally
approved these changes
May 24, 2024
src/fswAlgorithms/imageProcessing/centerOfBrightness/_UnitTest/test_centerOfBrightness.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/_UnitTest/test_centerOfBrightness.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/_UnitTest/test_centerOfBrightness.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/_UnitTest/test_centerOfBrightness.py
Outdated
Show resolved
Hide resolved
src/fswAlgorithms/imageProcessing/centerOfBrightness/_UnitTest/test_centerOfBrightness.py
Show resolved
Hide resolved
JulianHammerl
force-pushed
the
feature/833-cob-windowing
branch
from
a17cea8 to
7b6ae00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The centerOfBrightness module was updated to accept the input parameters for a masking window, and the module then applies that window to only consider pixels within the window for the computation of the center of brightness.
Verification
The unit test was updated to check the windowing approach.
Documentation
The documentation was updated accordingly.
Future work
At the moment, swig_eigen.i doesn't include the Eigen::Vector2i type, so Eigen::VectorXi was used instead for the corresponding windowing input parameters. This should be changed once the swig_eigen.i file has been updated.