Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/258 sunSearch #259

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Feature/258 sunSearch #259

merged 7 commits into from
Jun 10, 2024

Conversation

rcalaon
Copy link
Collaborator

@rcalaon rcalaon commented May 30, 2024

  • Tickets addressed: bsk-258
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This module computes three consecutive bang-bang rate and acceleration profiles for 3 rotations about any combination of principal body axes. Repetitions of the same axis are allowed. The output is a guidance message in which the reference rate is subtracted from the spacecraft body rate to close the control loop. Depending on the CSS configuration, different rotation sequences sweeping different angles might be required in order to ensure that the Sun is found.

Verification

A UnitTest is provided to check the accuracy of the output.

Documentation

New documentation is provided with this module.

Future work

The module can be enhanced with more than 3 rotations if needed.

@rcalaon rcalaon added the enhancement New feature or request label May 30, 2024
@rcalaon rcalaon self-assigned this May 30, 2024
@rcalaon rcalaon linked an issue May 30, 2024 that may be closed by this pull request
@rcalaon rcalaon force-pushed the feature/258-sunSearch branch from d1cd944 to 8bad7d2 Compare May 30, 2024 21:19
@rcalaon rcalaon changed the title Feature/258 sun search Feature/258 sunSearch May 30, 2024
@rcalaon rcalaon force-pushed the feature/258-sunSearch branch 3 times, most recently from e8fab9a to 06d12a8 Compare June 3, 2024 16:33
@rcalaon rcalaon force-pushed the feature/258-sunSearch branch from 06d12a8 to 09ab8e9 Compare June 10, 2024 15:39
Copy link
Collaborator

@patkenneally patkenneally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
🔻 Issues to address before merge
🔶 Requests that should not block merge, but should at least be discussed
🔵 Recommendations that can be ignored if desired

Nice! Huge work. Let's chat about my little struct thought.

@rcalaon rcalaon force-pushed the feature/258-sunSearch branch from 09ab8e9 to 4893ff9 Compare June 10, 2024 20:03
@rcalaon rcalaon force-pushed the feature/258-sunSearch branch from 4893ff9 to b18994c Compare June 10, 2024 21:28
@patkenneally patkenneally merged commit 0ad89d0 into develop Jun 10, 2024
3 checks passed
@patkenneally patkenneally deleted the feature/258-sunSearch branch June 10, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

sunSearch module
2 participants