Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/187 tca module #268

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Feature/187 tca module #268

merged 4 commits into from
Jun 25, 2024

Conversation

safa2KH
Copy link
Collaborator

@safa2KH safa2KH commented Jun 10, 2024

  • Tickets addressed: bsk-187
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

The first commit creates time of closest approach payload message and the following commits adds time of closest approach module and test it. The last commit adds the documentation for the module.

Verification

Validated through unit test in python (Added to pytest)

Documentation

There is a rst file with the module

Future work

None

@safa2KH safa2KH force-pushed the feature/187-TCA-Module branch 5 times, most recently from 77163f9 to ef8482f Compare June 11, 2024 20:46
@safa2KH safa2KH force-pushed the feature/187-TCA-Module branch from ef8482f to 3fbe1f3 Compare June 18, 2024 16:46
Copy link
Collaborator

@thibaudteil thibaudteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get the CI to pass we can merge this, looks good

@patkenneally patkenneally force-pushed the feature/187-TCA-Module branch from 161c5a9 to de48265 Compare June 21, 2024 15:49
@patkenneally patkenneally force-pushed the feature/187-TCA-Module branch from de48265 to 9285505 Compare June 21, 2024 15:49
@patkenneally patkenneally force-pushed the feature/187-TCA-Module branch from 9285505 to 79f0376 Compare June 21, 2024 19:57
@patkenneally patkenneally merged commit 6f95db3 into develop Jun 25, 2024
3 checks passed
@patkenneally patkenneally deleted the feature/187-TCA-Module branch June 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants