Refactor/193 coarse sun sensor refactor #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcalaon
force-pushed
the
refactor/193-coarseSunSensor-refactor
branch
4 times, most recently
from
669ede0 to
8641f9e
Compare
patkenneally
approved these changes
Jun 18, 2024
rcalaon
force-pushed
the
refactor/193-coarseSunSensor-refactor
branch
from
8641f9e to
11bd66a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This modification features the ability to define a custom field of view (FOV) for the CSS. Such field of view is defined as the union of two half ellipses on the XY plane of the CSS's frame. The CSS's Z axis is aligned with the boresight of the sensor.
The resulting figure in the XY plane is symmetric with respect to X = 0 plane. Along the ±Y axis, the user can specify different FOV amplitudes, effectively mimicking the presence of baffles. Baffles along the ±X axis can also be defined, but they have the same amplitude by design.
Verification
A UnitTest is added to test that, using the custom FOV, the Sun's angle with respect to the CSS's boresight is computed correctly.
Documentation
Documentation is updated to reflect the changes.
Future work
n/a