Resolve numpy warning in sunline srukf test #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The show plot controls are better kept outside the plotting functions. The plotting functions now have a single responsibility which is to produce and return a plot. It is then left to the calling code to decide with to show() the plot, save the plot as an image, etc.
patkenneally
force-pushed
the
feature/fix-numpy-warning-sunline-srukf-test
branch
2 times, most recently
from
0da32bd to
7f5f589
Compare
Show plots is not a test parameter. It is passed in by the pytest framework. For functions that need a default value, that value should be set as a defaulted function parameter.
This warned of numpy 1.25.0 deprecated behavior where a list or dim-0 arrays are treated as scalars. Instead one must index specifically into the array/list.
patkenneally
force-pushed
the
feature/fix-numpy-warning-sunline-srukf-test
branch
from
7f5f589 to
2a2b154
Compare
patkenneally
changed the title
thibaudteil
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a numpy deprecation warning in the
test_sunlineSRuKFtest. Specifically: Only ndim-0 arrays are treated as scalars. NumPy used to treat all arrays of size 1 (e.g., np.array([3.14])) as scalars. In the future, this will be limited to arrays of ndim 0 (e.g., np.array(3.14)).The PR performs a few clean up operations in the first four commits. The warning is resolved in the final commit.
Verification
CI to run successfully.
Documentation
NA
Future work
NA