Remove --gtest_output flag #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brsm3129
force-pushed
the
feature/fix-gtest-output
branch
2 times, most recently
from
40a9bd6 to
7f67b1f
Compare
brsm3129
force-pushed
the
feature/fix-gtest-output
branch
from
7f67b1f to
f39a845
Compare
patkenneally
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the need for pre-commit to run before the other tests and stops storing the output of ctest which was breaking tests earlier.
Verification
All changes are verified by current tests.
Documentation
None
Future work
In the future we may want to move to XML output storing.