599 fix cob measurement noise #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianHammerl
force-pushed
the
599-fix-cob-measurement-noise
branch
2 times, most recently
from
e3747af to
49be469
Compare
thibaudteil
approved these changes
Sep 19, 2024
src/fswAlgorithms/opticalNavigation/cobConverter/cobConverter.rst
Outdated
Show resolved
Hide resolved
JulianHammerl
force-pushed
the
599-fix-cob-measurement-noise
branch
2 times, most recently
from
47cb26c to
8268023
Compare
patkenneally
approved these changes
Sep 28, 2024
src/fswAlgorithms/opticalNavigation/cobConverter/cobConverter.cpp
Outdated
Show resolved
Hide resolved
JulianHammerl
force-pushed
the
599-fix-cob-measurement-noise
branch
4 times, most recently
from
176a9c4 to
14b8d17
Compare
The covariance should increase with number of pixels, not decrease
patkenneally
force-pushed
the
599-fix-cob-measurement-noise
branch
from
14b8d17 to
6f6603d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The computation of the COB error covariance was updated such that the measurement noise increases with number of pixels, instead of decreasing. Additionally, the covariance of the attitude uncertainty was included to compute the total covariance matrix.
Verification
The UnitTest was updated.
Documentation
The documentation was updated.
Future work
N/A