Change tests to use tempfile #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
fix/change-test-to-use-tempfile
branch
from
2b6fed4 to
a549525
Compare
Twisol
reviewed
Sep 24, 2024
src/utilities/MonteCarlo/_UnitTests/test_scenarioBasicOrbitMC.py
Outdated
Show resolved
Hide resolved
patkenneally
force-pushed
the
fix/change-test-to-use-tempfile
branch
2 times, most recently
from
33dbeee to
a9501ea
Compare
patkenneally
force-pushed
the
fix/change-test-to-use-tempfile
branch
from
a9501ea to
d5445dd
Compare
thibaudteil
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests shouldn't be creating directories in the source tree. Rather we should use managed contexts that manage temporary files and directories.
Verification
CI test run unchanged.
Documentation
NA
Future work
NA