Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inertial attitude ukf to accept IMUSensorMsgPayload #349

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

leahkiner
Copy link
Collaborator

@leahkiner leahkiner commented Sep 27, 2024

  • Tickets addressed: bsk-348
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This PR refactors the inertialAttitudeUkf module to accept the IMUSensorMsgPayload message. Currently, the inertialAttitudeUkf module accepts the AccDataMsgPayload message. A separate converter module is also added to this PR to convert from the AccDataMsgPayload message to the IMUSensorMsgPayload message. The result of this PR is the ability to either subscribe the imuSensor module output IMUSensorMsgPayload message directly to the inertialAttitudeUkf module, or to use the new converter module to convert the more realistic AccDataMsgPayload message to the IMUSensorMsgPayload message and subsequently subscribe the IMUSensorMsgPayload message to the inertialAttitudeUkf module.

The first commit of this PR adds two new variables to the IMUSensorMsgPayload: timeTag and numberOfValidGyroMeasurements. These parameters are required to be known in the inertialAttitudeUkf module. The second commit of this PR refactors the inertialAttitudeUkf module to accept the IMUSensorMsgPayload message. The third commit adds a miruLowPassFilterConverter to the sensorInterfaces folder that will interface with the inertialAttitudeUkf module. The fourth commit adjusts the inertialAttitudeUkf unit test file to use the new IMUSensorMsgPayload message.

Verification

N/A

Documentation

N/A

Future work

N/A

@leahkiner leahkiner self-assigned this Sep 27, 2024
@leahkiner leahkiner force-pushed the refactor/refactor-inertial-attitude-ukf branch from 05daade to 16de569 Compare September 27, 2024 22:59
Copy link
Collaborator

@thibaudteil thibaudteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to update the test to read the ImuSensor message.

@leahkiner leahkiner force-pushed the refactor/refactor-inertial-attitude-ukf branch 3 times, most recently from 5be4d1f to fdcf570 Compare September 30, 2024 22:14
@leahkiner leahkiner force-pushed the refactor/refactor-inertial-attitude-ukf branch from fdcf570 to d059227 Compare September 30, 2024 22:42
@leahkiner leahkiner linked an issue Sep 30, 2024 that may be closed by this pull request
@leahkiner leahkiner force-pushed the refactor/refactor-inertial-attitude-ukf branch 3 times, most recently from e247d9a to 9a6ec38 Compare March 3, 2025 21:40
@leahkiner leahkiner requested a review from codyallard28 March 10, 2025 21:59
@leahkiner leahkiner force-pushed the refactor/refactor-inertial-attitude-ukf branch from 9a6ec38 to 9fc0cac Compare March 10, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Refactor inertialAttitudeUkf to accept IMUSensorMsgPayload message
2 participants