Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing permissions in Pages workflow #523

Merged
merged 2 commits into from
May 18, 2024

Conversation

muzimuzhi
Copy link
Contributor

@muzimuzhi muzimuzhi commented May 17, 2024

Status

READY

Description

actions/jekyll-build-pages is a Docker action hence is run by the default Docker user (root). So we need sudo in copying into the directory created by Jekyll. See actions/jekyll-build-pages#101.

https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user

Due to branch filtering setting, this PR won't trigger workflow jekyll-gh-pages.yml. See a successful testing run https://github.com/muzimuzhi/fontspec/actions/runs/9129444592/job/25104020051, in which the branch filtering rule is relaxed.

muzimuzhi added 2 commits May 17, 2024 21:56
actions/jekyll-build-pages is a Docker action hence is run by the default Docker
user (root). So we need sudo in copying into the directory created by Jekyll.
See actions/jekyll-build-pages#101.

https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user
@wspr
Copy link
Collaborator

wspr commented May 18, 2024

ah, so easy when you know how :)

@wspr wspr merged commit 212f5ad into latex3:develop May 18, 2024
3 checks passed
@muzimuzhi
Copy link
Contributor Author

muzimuzhi commented May 18, 2024

BTW there're actions that allow debugging of GitHub Actions runs by using SSH:

@muzimuzhi muzimuzhi deleted the pages/fix-permissions branch May 18, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants