Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP / Fix actions overlap tabs in document log detail when screen is small #663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP / Fix actions overlap tabs in document log detail when screen is small #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...Id]/versions/[commitUuid]/documents/[documentUuid]/_components/MetadataInfoTabs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,21 @@ export const MetadataInfoTabs = forwardRef<HTMLDivElement, Props>(
<div
ref={ref}
className={cn(
'flex flex-col flex-grow min-h-0 bg-background overflow-hidden',
'flex flex-col flex-grow flex-shrink-0 min-h-0 bg-background w-auto',
'border border-border rounded-lg items-center relative',
className,
)}
>
<div className='pt-6 pb-2 relative flex justify-center w-full'>
<div className='pt-6 pb-2 flex flex-row w-full px-4'>
<div className='flex-1 flex justify-end'>{/* Left spacer */}</div>
<TabSelector
options={tabs}
selected={selectedTab}
onSelect={setSelectedTab}
/>
{tabsActions ? (
<div className='absolute right-4 top-6 flex items-center justify-end w-full min-h-11 pointer-events-none'>
{tabsActions}
</div>
) : null}
<div className='flex-1 flex justify-end min-h-11 pl-4 pointer-events-none'>
{tabsActions && <>{tabsActions}</>}
</div>
</div>
<div className='w-full custom-scrollbar overflow-y-auto'>
<div className='flex px-4 py-5 flex-col gap-4 w-full overflow-x-auto'>
Expand Down
2 changes: 1 addition & 1 deletion ...]/evaluations/[evaluationId]/_components/EvaluationResults/EvaluationResultInfo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function DocumentLogInfoModal({
<DocumentLogInfo
documentLog={documentLog!}
providerLogs={providerLogs}
evaluationResults={evaluationResults[documentLogId]}
evaluationResults={evaluationResults[documentLogId] || []}
isLoading={isLoading}
error={errorDocumentLog}
/>
Expand Down
2 changes: 1 addition & 1 deletion ...d]/versions/[commitUuid]/documents/[documentUuid]/logs/_components/DocumentLogs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export function DocumentLogs({
<DocumentLogInfo
documentLog={selectedLog}
providerLogs={providerLogs}
evaluationResults={evaluationResults[selectedLog.id]}
evaluationResults={evaluationResults[selectedLog.id] || []}
isLoading={isProviderLogsLoading || isEvaluationResultsLoading}
stickyRef={stickyRef}
sidebarWrapperRef={sidebarWrapperRef}
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/hooks/useStickyNested.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@ export function useStickyNested({
}
}, [scrollableArea, beacon, target, offset])

useUpdateWidthOnTargetContainerChange({ target, targetContainer })
// useUpdateWidthOnTargetContainerChange({ target, targetContainer })
}
Loading