-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mega PR: First iteration of prover and verifier #13
Conversation
The second `truncate(Self::DEGREE_BOUND)` call in the polynomial reduction step is unnecessary.
Refactor: separating up code, fix clippy
refactor: verifier and prover reorg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps no need to address the comments, we could discuss and if the issue make sense we create issues to fix after the pr is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work 🙏, will approve the pr 🙏 we could still check the discussion here and continue the fix with issues after merging.
My advice in algebra :) (1) The coefficient of
(2) should check overflow in example:
|
linked the unresolved comments to the issues, we'll merge this pr and continue the fixes from there 🚀 |
Implemented a rough prover and verifier, includes:
Next stage work: