Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifier #16

Merged
merged 65 commits into from
Dec 28, 2024
Merged

Verifier #16

merged 65 commits into from
Dec 28, 2024

Conversation

luckyyang
Copy link
Collaborator

Add all computations for verifier checks.

Todos:

  • choose proper parameters
  • improve aggregation relation check logic, there is a workaround by truncating the coefficients from conjugation automorphism to pass the check, we should resolve this

@luckyyang
refactor: rename variables
4419a07
@luckyyang
feat: verify g and h are symmetric
96421f4
@luckyyang
fix norm calculation
b3aa763
@luckyyang
feat: add norm calculation for data structures with more dimension
f795a77
@luckyyang
feat: larger beta
9aa0ab8
@luckyyang
refactor decomposition
a81d89e
@luckyyang
feat: update bata for prover to pass the test
b3251f9
@luckyyang
feat: verifier to verify aggregated norm from z, t, g, h
b10530f
@luckyyang
test: use 2 as random number to facilitate test
19a0b93
@luckyyang
fix matrix of polynomial times vector of polynomial
48df596
@luckyyang
feat: add operations for vector of polynomial
163ff72
@luckyyang
fix amortization calculation, c should be vector of polynomial
c5c8a8c
@luckyyang
feat: verifier to verify az = ct
22125af
@luckyyang
test: add test for inner product between polynomial vector
41770ce
@luckyyang
test: check g value from j = 0
15a832f
@luckyyang
refactor: add inner product between matrix of polynomial and vector o…
0dfa6c1 
…f polynomial
@luckyyang
test: add test for inner product
7223d01
@luckyyang
refactor: add length check for inner product
261f083
@luckyyang
fix parameter order issue
87a14c7
@luckyyang
feat: verifier to check: <z, z> ?= sum(g_ij * c_i * c_j), refer to pa…
70d94fc 
…per verifier line 16 check
@luckyyang
refactor: rename
b65516c
@luckyyang
refactor: extract aggregation code into functions
badb5d9
@luckyyang
refactor: use zero polynomial to simplify code
2dd192d
@luckyyang
refactor: rename function names
9f2690b
@luckyyang
fix: Division should be divisible by other
cf8bff4
@luckyyang
refactor: remove unused code
417b37b
@luckyyang
feat: add functions to calculate aggregation for quadratic and consta…
bb2ce46 
…nt terms
@luckyyang
refactor: rename function, sort out code
d0f241c
@luckyyang
refactor: update random number range
04336c4
@luckyyang
fix: workaround for calculation h element that can not divide by 2
60cd15f
@Junochiu Junochiu changed the base branch from main to prover December 25, 2024 13:13
Junochiu
Junochiu reviewed Dec 26, 2024
View reviewed changes
labrador/src/prover.rs
b_constraint_ct: Vec<Zq>,
}

struct Tr {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is Tr stands for Transcript?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea when I was implementing. I think you are right

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha okk got it, I would like to update the name in the refactoring pr 🙏🏻

@Junochiu Junochiu merged commit e203997 into prover Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junochiu Junochiu Junochiu left review comments

@FoodChain1028 FoodChain1028 Awaiting requested review from FoodChain1028

@kurtpan666 kurtpan666 Awaiting requested review from kurtpan666

@pinhaocrypto pinhaocrypto Awaiting requested review from pinhaocrypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luckyyang @Junochiu @SuccinctPaul