feat(solhint-plugin-mud): create package #885
Conversation
| @@ -40,7 +40,8 @@ | |||
| "prettier-plugin-solidity": "^1.0.0-beta.19", | |||
| "rimraf": "^3.0.2", | |||
| "run-pty": "^4.0.3", | |||
| "solhint": "^3.3.7", | |||
| "solhint": "^3.4.1", | |||
| "solhint-plugin-mud": "file:../../../../packages/solhint-plugin-mud", | |||
There was a problem hiding this comment.
this should prob use link rather than file to match other mud deps?
There was a problem hiding this comment.
Oh I was thinking I wanted a comment there, but afaik I can't, right?
This is intentional, how pnpm does links conflicts with how solhint requires plugins apparently (my guess is something about flat node_modules, took a while to narrow this down)
There was a problem hiding this comment.
if we add this to templates, we need to adjust copy-templates.sh to also parse file: deps (not just link:)
although this probably wouldn't be captured there anyway since it doesn't have a @latticexyz/ prefix
| "rules": { | ||
| "compiler-version": ["error", ">=0.8.0"], | ||
| "avoid-low-level-calls": "off", | ||
| "no-inline-assembly": "off", | ||
| "func-visibility": ["warn", { "ignoreConstructors": true }], | ||
| "no-empty-blocks": "off", | ||
| "no-complex-fallback": "off" | ||
| "no-complex-fallback": "off", | ||
| "mud/no-msg-sender": "error" |
There was a problem hiding this comment.
any way to make this the default if you enable/use the plugin?
There was a problem hiding this comment.
a mud extension with defaults, that would be another package in a followup PR
Probably worth figuring this out? cc @alvrs @ludns @juanfranblanco was quite responsive with the foundry monorepo support once I got his attention :) |
|
regarding the issues - from what I understood the root one is on solhint side, they'd need to significantly change how plugins are loaded |
|
The issue with plugins was due to not being able to run them separately (IE providing a path) the package runs in the context of the extension not on the users workspace so it cannot find them. If this is changed it could be configured to look for plugins in a specific folder i.e user's node modules in her project. |
Co-authored-by: alvarius <89248902+alvrs@users.noreply.github.com>
fixes #711
seems to work well via cli (like via
solhintinpackage.jsonofexamples)caveats:
anybecause solhint doesn't export any types) and relies on@solidity-parser/parserfor some types (which solhint uses internally)To make it work in https://github.com/juanfranblanco/vscode-solidity these 2 issues would need to be resolved (stale, but I could probably do this myself if we wanna prioritize this):
protofire/solhint#206
juanfranblanco/vscode-solidity#169
I've also tried hardhat extension but immediately got remapping problems before even getting to solhint plugins, but maybe worth exploring alternatives
Haven't looked into solium yet, that may also be worth exploring