Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not turn off default features for url #3589

Open
hsivonen opened this issue Nov 4, 2024 · 2 comments
Open

Please do not turn off default features for url #3589

hsivonen opened this issue Nov 4, 2024 · 2 comments
Labels

Comments

@hsivonen
Copy link

hsivonen commented Nov 4, 2024

Bug Description

In d76b135 , sqlx-core turned off default features for url even though url didn't have default features at the time. This is disruptive now that url has introduced default features in order to manage catering to both the pre-existing MSRV-sensitive audience and to new no_std audience: servo/rust-url#992

Could you, please, remove default-features = false for url and publish a release?

Minimal Reproduction

rustup default 1.80
cargo new idna-992-repro
cd idna-992-repro/
cargo add sqlx
cargo check

Info

  • SQLx version: 0.8.2
  • SQLx features enabled: Default
  • Database server and version: Not applicable.
  • Operating system: Any
  • rustc --version: 1.80.1
@hsivonen
Copy link
Author

hsivonen commented Nov 5, 2024

It appears that sqlx-core isn't the only SQLx crate with this problem but sqlx-macros-core has the same thing.

@qrilka
Copy link

qrilka commented Nov 7, 2024

This issue broke our CI :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants