Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back impl core::error::Error #994

Closed
wants to merge 1 commit into from
Closed

Conversation

hsivonen
Copy link
Collaborator

@hsivonen hsivonen commented Nov 4, 2024

Fixes #992.

@hsivonen
Copy link
Collaborator Author

hsivonen commented Nov 4, 2024

Not sure if we should do this, but preparing the PR in case we decide to.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@da64903). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #994   +/-   ##
=======================================
  Coverage        ?   80.53%           
=======================================
  Files           ?       24           
  Lines           ?     4253           
  Branches        ?        0           
=======================================
  Hits            ?     3425           
  Misses          ?      828           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsivonen
Copy link
Collaborator Author

hsivonen commented Nov 4, 2024

Need to verify that this actually makes things work with sqlx-core in the depedency graph on Rust < 1.81.

@hsivonen
Copy link
Collaborator Author

hsivonen commented Nov 4, 2024

The failure for sqlx-core's url and idna to unify with the top level's interferes with testing this with a git override locally!

@hsivonen
Copy link
Collaborator Author

hsivonen commented Nov 4, 2024

After looking at this more, I think it would be better to get sqlx to change. sqlx opted out of default features for url when there weren't any, which isn't cool.

@hsivonen
Copy link
Collaborator Author

hsivonen commented Nov 4, 2024

Let's try to get sqlx fixed: launchbadge/sqlx#3589

@hsivonen hsivonen closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant