remove binary flag check on str for mysql #3726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Besides the fact that this breaks a bunch of tests, there's already a pending, more correct fix for the issue in question: #3400 This is a breaking change either way because it changes the type inference in the macros, so it has to wait until 0.9.0. Type overrides can be used in the meantime: https://docs.rs/sqlx/latest/sqlx/macro.query.html#type-overrides-output-columns |
|
@abonander Why have you closed PR if it have to wait? |
Collaborator
|
There's no reason to accept it over #3400, which addresses the issue in a more thorough manner. |
|
After a better read of both PRs, I agree with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this tries to fix issue. #3390