Initialise PSA signing context #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialise the PSA signing context in the PSA crypto adapter when the restartable signing API called with started==false. Change-Id: I9f5c40d2908f1cd32aa35b8d9562b63873d21471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing context initialization in the PSA crypto adapter for the restartable case.
The original implementation misses to call
psa_sign_hash_interruptible_operation_init()on the PSA sign function context. This doesn't cause a problem as long as the context structure is initialised to all 0, or a previous restartable signing with the same context was concluded earlier. However if the signing context of a previously interrupted signing is reused for a new signing operation,psa_sign_hash_startreturnsPSA_ERROR_BAD_STATE.