disregard last bits directly in hash function

laurentpayot · May 31, 2023 · 9e94d6b · 9e94d6b
1 parent b12b332
commit 9e94d6b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/minidenticons.js b/minidenticons.js
@@ -4,16 +4,14 @@ const DEFAULT_SATURATION = 50
 const DEFAULT_LIGHTNESS = 50
 
 
-// based on the FNV-1a hash algorithm (using `>>> 0` for 32 bit unsigned integer conversion)
-// http://www.isthe.com/chongo/tech/comp/fnv/index.html
+// based on the FNV-1a hash algorithm http://www.isthe.com/chongo/tech/comp/fnv/index.html
 /**
  * @type {(str: string) => number}
  */
 function simpleHash(str) {
     return str.split('')
-        .reduce((hash, char) => (((hash ^ char.charCodeAt(0)) >>> 0) * 16777619) >>> 0, 2166136261)
-        // disregarding last 4 bits for better randomness
-        >>> 4
+        // `>>> 0` for 32 bit unsigned integer conversion, `>>> 2` to disregard last 4 bits for better randomness
+        .reduce((hash, char) => (((hash ^ char.charCodeAt(0)) >>> 0) * 16777619) >>> 2, 2166136261)
 }
 
 /**

diff --git a/minidenticons.min.js b/minidenticons.min.js
diff --git a/minidenticons.min.js.map b/minidenticons.min.js.map
diff --git a/no-custom-element.min.js b/no-custom-element.min.js