custom element simplification

laurentpayot · Apr 14, 2023 · ef6e2f4 · ef6e2f4
1 parent 58c62a7
commit ef6e2f4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/minidenticons.js b/minidenticons.js
@@ -47,13 +47,9 @@ export const identiconSvg =
             static observedAttributes = ['username', 'saturation', 'lightness']
             // private fields to allow Terser mangling
             static #memoized = {}
-            #isConnected = false
-            connectedCallback() {
-                this.#setContent()
-                this.#isConnected = true
-            }
+            connectedCallback() { this.#setContent() }
             // attributeChangedCallback() is called for every observed attribute before connectedCallback()
-            attributeChangedCallback() { if (this.#isConnected) this.#setContent() }
+            attributeChangedCallback(name, oldValue) { if (oldValue !== null) this.#setContent() }
             #setContent() {
                 const args = IdenticonSvg.observedAttributes
                                 .map(key => this.getAttribute(key) || undefined)

diff --git a/minidenticons.min.js b/minidenticons.min.js
diff --git a/minidenticons.min.js.map b/minidenticons.min.js.map